From 47e67b0aa12758fcbe6eb68f95a35ceb66c268e7 Mon Sep 17 00:00:00 2001
From: ulrich
Date: Sun, 01 Dec 2024 16:25:09 +0000
Subject: [PATCH] Code aufgeraeumt
---
src/de/uhilger/neon/Factory.java | 223 +++++++++++++++++++++++++++++++++++--------------------
1 files changed, 142 insertions(+), 81 deletions(-)
diff --git a/src/de/uhilger/neon/Factory.java b/src/de/uhilger/neon/Factory.java
index ff5977d..48ceb6d 100644
--- a/src/de/uhilger/neon/Factory.java
+++ b/src/de/uhilger/neon/Factory.java
@@ -94,21 +94,23 @@
Gson gson = new Gson();
return gson.fromJson(sb.toString(), NeonDescriptor.class);
}
-
- public void runInstance(Class c, NeonDescriptor d)
- throws ClassNotFoundException, NoSuchMethodException, InstantiationException,
+
+ public void runInstance(Class c, NeonDescriptor d)
+ throws ClassNotFoundException, NoSuchMethodException, InstantiationException,
IllegalAccessException, IllegalArgumentException, InvocationTargetException, IOException {
this.runInstance(c, d, null, new ArrayList<>());
}
- public void runInstance(Class c, NeonDescriptor d, List<String> packageNames)
- throws ClassNotFoundException, NoSuchMethodException, InstantiationException,
+ public void runInstance(Class c, NeonDescriptor d, List<String> packageNames)
+ throws ClassNotFoundException, NoSuchMethodException, InstantiationException,
IllegalAccessException, IllegalArgumentException, InvocationTargetException, IOException {
this.runInstance(c, d, packageNames, new ArrayList<>());
}
+
/**
* Einen Neon-Server gemaess einem Serverbeschreibungsobjekt herstellen und starten
*
+ * @param starter die Klasse, mit der Neon durch Aufruf dieser Methode gestartet wird
* @param d das Object mit der Serverbeschreibung
* @param packageNames Namen der Packages, aus der rekursiv vorgefundene Actors eingebaut werden
* sollen
@@ -121,9 +123,12 @@
* @throws InvocationTargetException
* @throws IOException
*/
- public void runInstance(Class c, NeonDescriptor d, List<String> packageNames, List<DataProvider> sdp)
- throws ClassNotFoundException, NoSuchMethodException, InstantiationException,
+ public void runInstance(Class starter, NeonDescriptor d, List<String> packageNames, List<DataProvider> sdp)
+ throws ClassNotFoundException, NoSuchMethodException, InstantiationException,
IllegalAccessException, IllegalArgumentException, InvocationTargetException, IOException {
+
+ Logger.getLogger(Factory.class.getName()).log(Level.FINER, System.getProperty("java.class.path"));
+
List serverList = d.server;
Iterator<ServerDescriptor> serverIterator = serverList.iterator();
while (serverIterator.hasNext()) {
@@ -131,40 +136,40 @@
HttpServer server = HttpServer.create(new InetSocketAddress(sd.port), 0);
fireServerCreated(server);
- if(packageNames == null) {
+ if (packageNames == null) {
packageNames = d.actorPackages;
}
- addContexts(c, d, server, sd.contexts, packageNames, sdp);
+ addContexts(starter, d, server, sd.contexts, packageNames, sdp);
server.setExecutor(Executors.newFixedThreadPool(10));
server.start();
}
fireInstanceStarted();
}
-
+
private Authenticator createAuthenticator(NeonDescriptor d) {
Authenticator auth = null;
- if(d.authenticator != null) {
+ if (d.authenticator != null) {
try {
Object authObj = Class.forName(d.authenticator.className)
.getDeclaredConstructor().newInstance();
- if(authObj instanceof Authenticator) {
+ if (authObj instanceof Authenticator) {
auth = (Authenticator) authObj;
return auth;
}
- } catch (ClassNotFoundException | NoSuchMethodException | SecurityException |
- InstantiationException | IllegalAccessException | IllegalArgumentException |
- InvocationTargetException ex) {
+ } catch (ClassNotFoundException | NoSuchMethodException | SecurityException
+ | InstantiationException | IllegalAccessException | IllegalArgumentException
+ | InvocationTargetException ex) {
// Klasse nicht gefunden. Muss das geloggt oder sonstwie behandel werden?
return null;
- }
- }
+ }
+ }
return auth;
}
- private void addContexts(Class c, NeonDescriptor d, HttpServer server, List contextList, List<String> packageNames,
- List<DataProvider> sdp)
- throws ClassNotFoundException, NoSuchMethodException, InstantiationException,
+ private void addContexts(Class c, NeonDescriptor d, HttpServer server, List contextList, List<String> packageNames,
+ List<DataProvider> sdp)
+ throws ClassNotFoundException, NoSuchMethodException, InstantiationException,
IllegalAccessException, IllegalArgumentException, InvocationTargetException, IOException {
Map<String, HttpHandler> sharedHandlers = new HashMap();
Iterator<ContextDescriptor> contextIterator = contextList.iterator();
@@ -173,45 +178,45 @@
ContextDescriptor cd = contextIterator.next();
HttpHandler h = buildHandler(cd, sharedHandlers);
if (h != null) {
- HttpContext ctx = server.createContext(cd.contextPath, h);
+ HttpContext ctx = server.createContext(cd.contextPath, h);
Map<String, Object> ctxAttrs = ctx.getAttributes();
/*
Achtung: Wenn verschiedene Elemente dasselbe Attribut
deklarieren, ueberschreiben sie sich die Attribute gegenseitig.
*/
- ctxAttrs.putAll(cd.attributes);
- if (h instanceof Handler) {
+ ctxAttrs.putAll(cd.attributes);
+ if (h instanceof Handler) {
for (String packageName : packageNames) {
- wireActors(c,
- packageName, Actor.class, (Handler) h,
+ wireActors(c,
+ packageName, Actor.class, (Handler) h,
cd.attributes.get("contextName"));
- ctx.getAttributes().put("serverDataProviderList", sdp);
+ ctx.getAttributes().put("serverDataProviderList", sdp);
}
- }
- if(cd.authenticator instanceof String) {
- if(!(auth instanceof Authenticator)) {
+ }
+ if (cd.authenticator instanceof String) {
+ if (!(auth instanceof Authenticator)) {
auth = createAuthenticator(d);
}
- if(auth instanceof Authenticator) {
- ctx.setAuthenticator(auth);
+ if (auth instanceof Authenticator) {
+ ctx.setAuthenticator(auth);
ctx.getAttributes().putAll(d.authenticator.attributes);
fireAuthenticatorCreated(ctx, auth); // event umbenennen in etwas wie authAdded oder so
}
-
+
}
-
+
//Authenticator auth = createAuthenticator(d);
//if (auth instanceof Authenticator && cd.authenticator instanceof String) {
// ctx.setAuthenticator(auth);
// ctx.getAttributes().putAll(d.authenticator.attributes);
// fireAuthenticatorCreated(ctx, auth);
//}
- if(cd.filter != null) {
- for(String filterClassName : cd.filter) {
+ if (cd.filter != null) {
+ for (String filterClassName : cd.filter) {
//
Object filterObj = Class.forName(filterClassName)
- .getDeclaredConstructor().newInstance();
- if(filterObj instanceof Filter) {
+ .getDeclaredConstructor().newInstance();
+ if (filterObj instanceof Filter) {
Filter filter = (Filter) filterObj;
ctx.getFilters().add(filter);
}
@@ -224,10 +229,10 @@
}
}
}
-
- private HttpHandler buildHandler(ContextDescriptor cd, Map<String, HttpHandler> sharedHandlers) throws ClassNotFoundException, NoSuchMethodException, InstantiationException,
+
+ private HttpHandler buildHandler(ContextDescriptor cd, Map<String, HttpHandler> sharedHandlers) throws ClassNotFoundException, NoSuchMethodException, InstantiationException,
IllegalAccessException, IllegalArgumentException, InvocationTargetException, IOException {
- HttpHandler h;
+ HttpHandler h;
if (!cd.sharedHandler) {
h = getHandlerInstance(cd);
} else {
@@ -241,7 +246,7 @@
}
return h;
}
-
+
private HttpHandler getHandlerInstance(ContextDescriptor cd) {
try {
Object handlerObj = Class.forName(cd.className)
@@ -252,50 +257,102 @@
// kein HttpHandler aus newInstance
return null;
}
- } catch (ClassNotFoundException | NoSuchMethodException | SecurityException |
- InstantiationException | IllegalAccessException | IllegalArgumentException |
- InvocationTargetException ex) {
+ } catch (ClassNotFoundException | NoSuchMethodException | SecurityException
+ | InstantiationException | IllegalAccessException | IllegalArgumentException
+ | InvocationTargetException ex) {
// Klasse nicht gefunden. Muss das geloggt oder sonstwie behandel werden?
return null;
}
}
+ @SuppressWarnings("unchecked")
private void wireActors(Class c, String packageName, Class annotation, Handler h, String contextName) {
- JarScanner js = new JarScanner();
- URI path;
- try {
- path = js.getPath(c);
- if(path.toString().endsWith(".class")) {
- ClassLoader cl = c.getClassLoader();
- InputStream stream = cl
- .getResourceAsStream(packageName.replaceAll("[.]", "/"));
- BufferedReader reader = new BufferedReader(new InputStreamReader(stream));
- Iterator i = reader.lines().iterator();
- while (i.hasNext()) {
- String line = i.next().toString();
- if (line.endsWith(".class")) {
- try {
- Class actorClass = cl.loadClass(packageName + "."
- + line.substring(0, line.lastIndexOf('.')));
- if (actorClass != null && actorClass.isAnnotationPresent(annotation)) {
- wire(h, actorClass, contextName);
- }
- } catch (ClassNotFoundException ex) {
- // Klasse nicht gefunden. Muss das geloggt oder sonstwie behandel werden?
+ JarScanner js = new JarScanner(c, annotation);
+ if (!js.isJar()) {
+ ClassLoader cl = c.getClassLoader();
+ InputStream stream = cl
+ .getResourceAsStream(packageName.replaceAll("[.]", "/"));
+ BufferedReader reader = new BufferedReader(new InputStreamReader(stream));
+ Iterator i = reader.lines().iterator();
+ while (i.hasNext()) {
+ String line = i.next().toString();
+ if (line.endsWith(".class")) {
+ try {
+ Class actorClass = cl.loadClass(packageName + "."
+ + line.substring(0, line.lastIndexOf('.')));
+ if (actorClass != null && actorClass.isAnnotationPresent(annotation)) {
+ wire(h, actorClass, contextName);
}
- } else {
- wireActors(c, packageName + "." + line, annotation, h, contextName);
+ } catch (ClassNotFoundException ex) {
+ // Klasse nicht gefunden. Muss das geloggt oder sonstwie behandel werden?
}
+ } else {
+ wireActors(c, packageName + "." + line, annotation, h, contextName);
}
- } else {
- ClassLoader cl = js.getUrlClassLoader(c);
- js.processZipContent(cl, new File(path), packageName, this, h, contextName);
}
- } catch (URISyntaxException ex) {
- Logger.getLogger(Factory.class.getName()).log(Level.SEVERE, ex.getMessage(), ex);
+ } else {
+ js.processZipContent(packageName, this, h, contextName);
}
}
-
+
+ /**
+ * Diese Testmethode zeigt, dass die Methode getResourceAsStream nicht funktioniert wie
+ * dokumentiert.
+ *
+ * 1. Sie liefert den Inhalt einer gegebenen Package mitsamt Unterpackages als Stream, wenn sie
+ * auf eine Packagestruktur angewendet wird, die unverpackt in einem Verzeichnis des Dateisystems
+ * liegt.
+ *
+ * 2. Sie liefert - faelschlicherweise - null bzw. einen leeren Stream, wenn die Packagestruktur
+ * in einem Jar verpackt ist.
+ *
+ * Saemtliche Versuche, ueber den ClassPath oder die Pfadangabe der Package das Verhalten zu
+ * aendern, gehen bislang fehl (z.B. / oder . als Separator, / oder . zu Beginn enthalten oder
+ * nicht, realative oder absolute packagepfadangabe). Es ist auch unerheblich, ob
+ * Class.getResourceAsStream oder Class.getClassLoader().getResourceAsStream verwendet wird.
+ *
+ * Unabhaengig davon, ob und wie letztlich im Fall 2. oben die Methode getResourceAsStream dazu zu
+ * bringen waere, eine Inhaltsliste fuer eine Package zu liefern ist allein die Tatsache, dass
+ * sich die Methode unterschiedlich verhaelt bereits ein schwerer Bug.
+ *
+ * @param c
+ * @param packageName
+ */
+ private void listClasses(Class c, String packageName) {
+ Logger.getLogger(Factory.class.getName()).log(Level.FINER, "packageName: " + packageName);
+ //ClassLoader cl = c.getClassLoader();
+ String newPackageName = packageName.replaceAll("[.]", "/");
+ Logger.getLogger(Factory.class.getName()).log(Level.FINER, "newPackageName: " + newPackageName);
+ InputStream stream = c
+ .getResourceAsStream(newPackageName);
+ if (stream != null) {
+ BufferedReader reader = new BufferedReader(new InputStreamReader(stream));
+ Iterator i = reader.lines().iterator();
+ Logger.getLogger(Factory.class.getName()).log(Level.FINER, Long.toString(reader.lines().count()));
+ while (i.hasNext()) {
+ String line = i.next().toString();
+ Logger.getLogger(Factory.class.getName()).log(Level.FINER, "class to inspect: " + line);
+ if (line.endsWith(".class")) {
+ try {
+ Class actorClass = c.getClassLoader().loadClass(packageName + "."
+ + line.substring(0, line.lastIndexOf('.')));
+ if (actorClass != null && actorClass.isAnnotationPresent(Actor.class)) {
+ Logger.getLogger(Factory.class.getName()).log(Level.FINER, "ACTOR");
+ } else {
+ Logger.getLogger(Factory.class.getName()).log(Level.FINER, "no actor");
+ }
+ } catch (ClassNotFoundException ex) {
+ Logger.getLogger(Factory.class.getName()).log(Level.FINER, "Klasse nicht gefunden");
+ }
+ } else {
+ listClasses(c, packageName + "." + line);
+ }
+ }
+ } else {
+ Logger.getLogger(Factory.class.getName()).log(Level.FINER, "stream ist null");
+ }
+ }
+
/*
Eine Action-Annotation enthaelt gewoehnlich die Route,
die 'unterhalb' des Kontextpfades als 'Ausloeser' zur
@@ -304,7 +361,13 @@
Wenn die Action fuer alle Routen 'unterhalb' des
Kontextpfades ausgefuehrt werden soll, muss die Action
als Route '/' angeben.
- */
+ */
+ /**
+ *
+ * @param h Handler, dem der Actor hinzugefuegt wird, falls der Kontext uebereinstimmt
+ * @param c hinzuzufuegende Actor-Klasse
+ * @param contextName Name des Kontext, dem der Actor hinzugefuegt wird
+ */
private void wire(Handler h, Class c, String contextName) {
Method[] methods = c.getMethods();
for (Method method : methods) {
@@ -319,7 +382,6 @@
}
/* -------------- FactoryListener Implementierung --------------- */
-
private List<FactoryListener> listeners;
public void addListener(FactoryListener l) {
@@ -340,7 +402,7 @@
l.serverCreated(server);
}
}
-
+
private void fireHandlerCreated(HttpContext ctx, HttpHandler h) {
for (FactoryListener l : listeners) {
l.handlerCreated(ctx, h);
@@ -352,7 +414,7 @@
l.contextCreated(context);
}
}
-
+
private void fireAuthenticatorCreated(HttpContext context, Authenticator auth) {
for (FactoryListener l : listeners) {
l.authenticatorCreated(context, auth);
@@ -366,9 +428,8 @@
}
/* -------------- JarScannerListener Implementierung --------------- */
-
@Override
- public void actorFound(Class actorClass, Handler h, String contextName) {
- wire(h, actorClass, contextName);
+ public void annotationFound(Class foundClass, Handler h, String contextName) {
+ wire(h, foundClass, contextName);
}
-}
+}
\ No newline at end of file
--
Gitblit v1.9.3