From e0ec318eaf4c6f6129f57174bcb5873763541c13 Mon Sep 17 00:00:00 2001
From: ulrich <not disclosed>
Date: Fri, 06 Jan 2017 18:28:37 +0000
Subject: [PATCH] Digester auf SHA-256 umgestellt

---
 src/java/de/uhilger/um/api/UserMgr.java |  159 ++++++++++++++++++++++++++++++++++++-----------------
 1 files changed, 108 insertions(+), 51 deletions(-)

diff --git a/src/java/de/uhilger/um/api/UserMgr.java b/src/java/de/uhilger/um/api/UserMgr.java
index dc2c169..dcffb9c 100644
--- a/src/java/de/uhilger/um/api/UserMgr.java
+++ b/src/java/de/uhilger/um/api/UserMgr.java
@@ -1,38 +1,52 @@
 /*
- Nutzerverwaltung - A Generic User Manager
- Copyright (c) 2016  Ulrich Hilger
-
- This program is free software: you can redistribute it and/or modify
- it under the terms of the GNU Affero General Public License as published by
- the Free Software Foundation, either version 3 of the License, or
- (at your option) any later version.
-
- This program is distributed in the hope that it will be useful,
- but WITHOUT ANY WARRANTY; without even the implied warranty of
- MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- GNU Affero General Public License for more details.
-
- You should have received a copy of the GNU Affero General Public License
- along with this program.  If not, see <http://www.gnu.org/licenses/>.
+ *  Nutzerverwaltung - User and role management in your browser
+ *  Copyright (C) 2011-2016 Ulrich Hilger, http://uhilger.de
+ *
+ *  This program is free software: you can redistribute it and/or modify
+ *  it under the terms of the GNU General Public License as published by
+ *  the Free Software Foundation, either version 3 of the License, or
+ *  (at your option) any later version.
+ *
+ *  This program is distributed in the hope that it will be useful,
+ *  but WITHOUT ANY WARRANTY; without even the implied warranty of
+ *  MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ *  GNU General Public License for more details.
+ *
+ *  You should have received a copy of the GNU General Public License
+ *  along with this program.  If not, see http://www.gnu.org/licenses/
  */
+
 package de.uhilger.um.api;
 
 import de.uhilger.baselink.GenericRecord;
 import de.uhilger.baselink.PersistenceManager;
 import de.uhilger.baselink.Record;
-import de.uhilger.um.App;
+import de.uhilger.transit.web.WebKontext;
 import de.uhilger.um.Digester;
 import de.uhilger.um.daten.User;
 import de.uhilger.um.daten.UserRole;
 import java.sql.Connection;
 import java.util.List;
+import java.util.Properties;
+import javax.servlet.ServletContext;
 
 /**
- * Klasse zur Verwaltung von Benutzern und Rollen 
- * in einer Datenbank. Die Datenbankverbindung wird 
- * vom zentralen Anwendungsobjekt bereitgestellt. 
+ * <p>Die Methoden der Klasse UserMgr sind  
+ * die 'Fassade', die &uuml;ber Transit als Programmschnittstelle 
+ * (Application Programming Interface, API) 
+ * nach au&szlig;en bereitgestellt wird. UserMgr dient weitgehend 
+ * als 'Durchreiche' f&uuml;r die Funktionalit&auml;t anderer Klassen.</p>
  * 
- * Die SQL-Befehle finden sich in WEB-INF/sql.properties
+ * <p>
+ * Der UserMgr erh&auml;lt die ben&ouml;tigten Methoden aus dem ServletContext. 
+ * Auf diese Weise sind keine statischen Abh&auml;ngigkeiten in den Code 
+ * gewandert. Die folgenden Elemente werden vom UserMgr im ServletContext 
+ * erwartet:
+ * <ul>
+ * <li>PersistenceManager</li>
+ * <li>SQL-Properties</li>
+ * <li>Digester</li>
+ * </p> 
  * 
  * @author Copyright (c) Ulrich Hilger, http://uhilger.de
  * @author Published under the terms and conditions of the
@@ -41,40 +55,64 @@
  *
  * @version 2, December 27, 2016
  */
-public class UserMgr {
+public class UserMgr implements WebKontext {
   
-  private static final Record UserMapper = new GenericRecord(User.class);
-  private static final Record UserRoleMapper = new GenericRecord(UserRole.class);
+  /** Zeiger zum Servlet-Kontext dieser Anwendung */
+  private ServletContext ctx;
   
+  /** Name, unter dem das Properties-Objekt mit den SQL-Befehlen im ServletContext hinterlegt ist */
+  public static final String UM_SQL_PROPERTIES = "umSqlProperties";
+
+  /** Name, unter dem das Digester-Objekt im ServletContext hinterlegt ist */
+  public static final String P_DIGESTER = "digester";
+
+  /** Name, unter dem das Zugriffsobjekt zur Datenbank im ServletContext hinterlegt ist */
+  public static final String UM_DB = "umDb";
+  
+  /** Boolean-Konstante zur Kennzeichnung von Datenbankergebnissen ohne Blobs */
+  public static final boolean WITHOUT_BLOBS = false;
+
+  /** Referenz zum SQL-Befehl zur Ermittlung der Benutzer */
   public static final String SQL_GET_USER_LIST = "getUserList";
+  /** Referenz zum SQL-Befehl zur Ermittlung der Benutzer-Namen */
   public static final String SQL_GET_USER_NAME_LIST = "getUserNameList";
+  /** Referenz zum SQL-Befehl zur Ermittlung der Rollen */
   public static final String SQL_GET_ROLE_LIST = "getRoleList";
+  /** Referenz zum SQL-Befehl zur Ermittlung der Rollen eines Benutzers */
   public static final String SQL_GET_USER_ROLES = "getUserRoles";
-  public static final String SQL_DELETE_USER = "deleteUser";
+  /** Referenz zum SQL-Befehl zum Loeschen aller Rollen eines Nutzers */
   public static final String SQL_DELETE_USER_ROLES = "deleteUserRoles";
+  
+  /** Mapper-Objekt fuer Benutzer */
+  private static final Record UserMapper = new GenericRecord(User.class);
+  /** Mapper-Objekt fuer Benutzerrollen */
+  private static final Record UserRoleMapper = new GenericRecord(UserRole.class);
   
   /* ----------- Benutzer -------------- */
   
-  public User createUser(User user) {
+  public User createUser(User user) throws ClassNotFoundException, InstantiationException, IllegalAccessException {
     String kw = user.getPw();
-    String digestedPw = App.getDigester().digest(kw, Digester.MD5, null);
+    String digesterClassName = ctx.getInitParameter(P_DIGESTER);
+    Digester digester = (Digester) Class.forName(digesterClassName).newInstance();
+    /*
+      MD5 geht nicht mehr,
+      vgl. http://stackoverflow.com/questions/39967289/how-to-use-digest-authentication-in-tomcat-8-5
+    */
+    String digestedPw = digester.digest(kw, Digester.SHA256, null);
     user.setPw(digestedPw);
-    App.getDatabase().insert(user, UserMapper);
+    getDb().insert(user, UserMapper);
     return user;
   }
   
   public List getUserNameList() {
-    String sql = App.getSqlStatement(SQL_GET_USER_NAME_LIST);
-    List userNames = App.getDatabase().select(sql, App.WITHOUT_BLOBS);
-    return userNames;
+    return getDb().select(getSql(SQL_GET_USER_NAME_LIST), WITHOUT_BLOBS);
   }
   
   public User deleteUser(User user) {
-    PersistenceManager pm = App.getDatabase();
+    PersistenceManager pm = getDb();
     Connection c = pm.getConnection();
     pm.startTransaction(c);
-    String sql = App.getSqlStatement(SQL_DELETE_USER_ROLES);
-    pm.execute(c, sql, user.getId());
+    pm.execute(c, getSql(SQL_DELETE_USER_ROLES), user.getId());
     User deletedUser = (User) pm.delete(c, user, UserMapper);
     pm.commit(c);
     return deletedUser;
@@ -82,32 +120,51 @@
     
   /* ------------ Rollen ------------------ */
   
-  public UserRole grantRole(String userId, String roleName) {
-    UserRole ur = new UserRole();
-    ur.setRole(roleName);
-    ur.setUser(userId);
-    App.getDatabase().insert(ur, UserRoleMapper);
-    return ur;
+  public UserRole grantRole(UserRole role) {
+    getDb().insert(role, UserRoleMapper);
+    return role;
   }
   
-  public UserRole revokeRole(String userId, String roleName) {
-    UserRole ur = new UserRole();
-    ur.setRole(roleName);
-    ur.setUser(userId);
-    App.getDatabase().delete(ur, UserRoleMapper);
-    return ur;
+  public UserRole revokeRole(UserRole role) {
+    getDb().delete(role, UserRoleMapper);
+    return role;
   }
   
   public List getRoleNamesGranted() {
-    String sql = App.getSqlStatement(SQL_GET_ROLE_LIST);
-    List roleNames = App.getDatabase().select(sql, App.WITHOUT_BLOBS);
-    return roleNames;
+    return getDb().select(getSql(SQL_GET_ROLE_LIST), WITHOUT_BLOBS);
   }
   
   public List getUserRoleNames(String userId) {
-    String sql = App.getSqlStatement(SQL_GET_USER_ROLES);
-    List roleNames = App.getDatabase().select(sql, App.WITHOUT_BLOBS, userId);
-    return roleNames;
+    return getDb().select(getSql(SQL_GET_USER_ROLES), WITHOUT_BLOBS, userId);
   }
   
+  /* ----------- Helfer ---- */
+  
+  /**
+   * Ein benanntes SQL-Kommando ermitteln 
+   * @param id Name des gewuenschten SQL-Kommandos
+   * @return das SQL-Kommando mit der in id angegebenen Bezeichnung 
+   */
+  private String getSql(String id) {
+    Properties sql = (Properties) ctx.getAttribute(UserMgr.UM_SQL_PROPERTIES);
+    return sql.getProperty(id);
+  }
+  
+  private PersistenceManager getDb() {
+    return (PersistenceManager) ctx.getAttribute(UM_DB);
+  }
+  
+  /* ------------- Implementierung WebKontext ------------- */
+
+  @Override
+  public ServletContext getServletContext() {
+    return ctx;
+  }
+
+  @Override
+  public void setServletContext(ServletContext servletContext) {
+    this.ctx = servletContext;
+  }
+  
+  
 }

--
Gitblit v1.9.3